Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PHPstan errors #2

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Fixes PHPstan errors #2

merged 1 commit into from
Mar 2, 2024

Conversation

thejimbirch
Copy link
Contributor

Description

Teamwork Ticket(s): insert_ticket_name_here

As a developer, I need to start with a story.

A few sentences describing the overall goals of the pull request's commits.
What is the current behavior of the app? What is the updated/expected behavior
with this PR?

Acceptance Criteria

  • A list describing how the feature should behave
  • e.g. Clicking outside a modal will close it
  • e.g. Clicking on a new accordion tab will not close open tabs

Assumptions

  • A list of things the code reviewer or project manager should know
  • e.g. There is a known Javascript error in the console.log
  • e.g. On any multidev, the popup plugin breaks.

Steps to Validate

  1. A list of steps to validate
  2. Include direct links to test sites (specific nodes, admin screens, etc)
  3. Be explicit

Affected URL

link_to_relevant_multidev_or_test_site

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc. This should also include work that needs to be
accomplished post-launch like enabling a plugin.

@thejimbirch thejimbirch merged commit 43655ff into main Mar 2, 2024
@thejimbirch thejimbirch deleted the thejimbirch-patch-1 branch March 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant