♻️ make function kpt compatible #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpt only does a function at once, and honors the removal of the `config.kuberntes.io/local-config` marked resources. In consequence, we cannot use `config.kuberntes.io/local-config` anymore to inject resources. We replace it with `config.kaweezle.com/local-config`. `prune-local` is not a workaround anymore but becomes a feature. The README needs to be adapted in consequence.
kpt wants a function configuration at once.
- Now annotations are explicit. To make a resource local to the transformation, you need to add the annotation `config.kaweezle.com/local-config`. - The previous means that without annotation, generated resources will be saved. However, they will be saved in a file named `.krmfnbuiltin.yaml` - There is no more `keep-local` as it is not needed anymore. - Documentation needs to be updated.
Uses the selectors used for patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kpt only does a function at once, and honors the removal
of the
config.kuberntes.io/local-configmarked resources.In consequence, we cannot use
config.kuberntes.io/local-configanymore to inject resources. We replace it with
config.kaweezle.com/local-config.prune-localis not a workaround anymore but becomesa feature. The README needs to be adapted in consequence.