Skip to content

Commit

Permalink
libcamera: software_isp: Remove TODO about internal representation
Browse files Browse the repository at this point in the history
TODO #4 was recorded at a time where the IPA module computed gain values
and the ISP computed the look up tables.  The gains were higher-level
parameters.  Now that the look up tables are computed in the IPA module,
the IPA and ISP are more tightly coupled and the TODO item is less
relevant.

Let's drop the TODO item.  We may or may not need to switch to a
different representation in future but there is currently no good need
for this and the conversion of the values would be just waste of CPU
cycles.

Signed-off-by: Milan Zamazal <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Laurent Pinchart <[email protected]>
  • Loading branch information
mz-pdm authored and pinchartl committed Jun 1, 2024
1 parent f5b7921 commit a52d818
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions src/libcamera/software_isp/TODO
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,6 @@ stats in hardware, such as the i.MX7), but please keep it on your radar.

---

4. Hide internal representation of gains from callers

> struct DebayerParams {
> static constexpr unsigned int kGain10 = 256;

Forcing the caller to deal with the internal representation of gains
isn't nice, especially given that it precludes implementing gains of
different precisions in different backend. Wouldn't it be better to pass
the values as floating point numbers, and convert them to the internal
representation in the implementation of process() before using them ?

---

5. Store ISP parameters in per-frame buffers

> /**
Expand Down

0 comments on commit a52d818

Please sign in to comment.