fix: rm the 'Result::unwrap()' in lsp. (#571)

* fix: rm the 'Result::unwrap()' in lsp.

* fix: return error if kpm metadata failed.

* fix: fix test cases

* fix: make fmt.

kclvm/driver/src/kpm_metadata.rs

@@ -57,22 +57,25 @@ impl Metadata {
 
 /// [`fetch_metadata`] will call `kpm metadata` to obtain the metadata.
 pub fn fetch_metadata(manifest_path: PathBuf) -> Result<Metadata> {
-    let output = Command::new(kpm())
+    use std::result::Result::Ok;
+    match Command::new(kpm())
         .arg("metadata")
         .current_dir(manifest_path)
         .output()
-        .unwrap();
-
-    if !output.status.success() {
-        bail!(
-            "fetch workspace failed with error: {}",
-            String::from_utf8_lossy(&output.stderr)
-        );
+    {
+        Ok(output) => {
+            if !output.status.success() {
+                bail!(
+                    "fetch metadata failed with error: {}",
+                    String::from_utf8_lossy(&output.stderr)
+                );
+            }
+            Ok(Metadata::parse(
+                String::from_utf8_lossy(&output.stdout).to_string(),
+            )?)
+        }
+        Err(err) => bail!("fetch metadata failed with error: {}", err),
     }
-
-    Ok(Metadata::parse(
-        String::from_utf8_lossy(&output.stdout).to_string(),
-    )?)
 }
 
 /// [`lookup_the_nearest_file_dir`] will start from [`from`] and search for file [`the_nearest_file`] in the parent directories.

kclvm/driver/src/tests.rs

@@ -1,5 +1,5 @@
-use std::env;
 use std::path::{Path, PathBuf};
+use std::{env, panic};
 
 use kclvm_config::modfile::get_vendor_home;
 use kclvm_config::settings::KeyValuePair;
@@ -196,3 +196,23 @@ fn test_fetch_metadata() {
             .to_string()
     );
 }
+
+#[test]
+fn test_fetch_metadata_invalid() {
+    let result = panic::catch_unwind(|| {
+        let result = fetch_metadata("invalid_path".to_string().into());
+        match result {
+            Ok(_) => {
+                panic!("The method should not return Ok")
+            }
+            Err(_) => {
+                println!("return with an error.")
+            }
+        }
+    });
+
+    match result {
+        Ok(_) => println!("no panic"),
+        Err(e) => panic!("The method should not panic forever.: {:?}", e),
+    }
+}