Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Resolver doc parser performance problem #576

Closed
He1pa opened this issue Jun 16, 2023 · 0 comments · Fixed by #619
Closed

[Enhancement] Resolver doc parser performance problem #576

He1pa opened this issue Jun 16, 2023 · 0 comments · Fixed by #619
Assignees
Labels

Comments

@He1pa
Copy link
Contributor

He1pa commented Jun 16, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

compile:
https://github.com/KusionStack/konfig/blob/main/base/examples/native/nginx_deployment/nginx_deployment.k

2. What did you expect to see? (Required)

3. What did you see instead (Required)

image

Each fragment at the top of the figure represents once call of parser_doc_string.
This function takes estimated 60-70% of the resolver time. After removing this function, the resolver time dropped from 70ms to 14ms

4. What is your KusionStack components version? (Required)

@Peefy Peefy changed the title [Bug] Resover doc parser performance problem [Enhancementt] Resolver doc parser performance problem Jun 16, 2023
@Peefy Peefy added the resolver label Jun 16, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone Jun 16, 2023
@Peefy Peefy changed the title [Enhancementt] Resolver doc parser performance problem [Enhancement] Resolver doc parser performance problem Jun 19, 2023
@Peefy Peefy modified the milestones: v0.5.0 Release, v0.6.0 Release Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants