Added Blake3 implementation using blake3 crate #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prakhar Singhal <[email protected]> Added tests for blake3 implementation Signed-off-by: Prakhar Singhal <[email protected]> added/integrated blake3 function to crypto lib Signed-off-by: Prakhar Singhal <[email protected]> Added tests for blake3 in grammer tests Signed-off-by: Prakhar Singhal <[email protected]> Addded external dependency in cargo.toml and fixed formatting Signed-off-by: Prakhar Singhal <[email protected]>
|
@Peefy can you take a look thanks! |
|
Thanks for the contribution. The CI failed, and could you please fix it. |
Peefy
reviewed
Aug 30, 2024
.../LSP/src/snapshots/kcl_language_server__completion__tests__import_external_pkg_test.snap.new
Outdated
Show resolved
Hide resolved
Signed-off-by: Prakhar Singhal <[email protected]>
|
I'll merge this PR and could you please fix CI issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added/integrated blake3 function to crypto lib
Added tests for blake3 implementation
Added tests for blake3 in grammer tests
Addded external dependency in cargo.toml and fixed formatting
1. Does this PR affect any open issues?(Y/N) :
adds
re Add BLAKE-3 to crypto module #1592
2. What is the scope of this PR (e.g. component or file name):
kclvm/runtime/src/cryptokclvm/tests/test/grammer/builtins/cypto3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
added blake3 hashing method for provided crypto module
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
Unit tests:
test/test_units/runtime/crypto/test_crypto.pyGrammer tests:
test/grammer/builtins/crypto/blake