Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Removed extra newline in kcl.mod #427

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Manoramsharma
Copy link
Contributor

@Manoramsharma Manoramsharma commented Aug 1, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fixes #426

2. What is the scope of this PR (e.g. component or file name):

/pkg/package/toml.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

After changes
Screenshot 2024-08-01 at 8 44 43 PM

@coveralls
Copy link

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10213564931

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 40.253%

Totals Coverage Status
Change from base Build 10198962112: -0.008%
Covered Lines: 3120
Relevant Lines: 7751

💛 - Coveralls

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good jobs!

Could you please add a test for it?

I believe that it is like:

func TestInitEmptyPkg(t *testing.T) {
...
// test before
data1,err:=os.ReadFile("kcl.mod")
... // testing
// test after
data2,err:=os.ReadFile("kcl.mod")
assert.Equal(t, data1, data2)
}

@liangyuanpeng
Copy link
Contributor

cc @zong-zhe ^^^

@Peefy
Copy link
Contributor

Peefy commented Aug 2, 2024

Cloud you please leave a newline at the end of file?

Signed-off-by: Manoramsharma <[email protected]>
@Manoramsharma
Copy link
Contributor Author

Cloud you please leave a newline at the end of file?

Done @Peefy PTAL !!!

@Peefy Peefy merged commit 04d2b16 into kcl-lang:main Aug 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: extra newline in kcl.mod Enhancement: kpm add command displaying optimization
4 participants