Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use repo name in name and fullname #461

Conversation

officialasishkumar
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@officialasishkumar
Copy link
Contributor Author

@Peefy PTAL

@Peefy
Copy link
Contributor

Peefy commented Aug 22, 2024

Any tests for this change?

@officialasishkumar
Copy link
Contributor Author

Yeah updating

Signed-off-by: Asish Kumar <[email protected]>
@Peefy
Copy link
Contributor

Peefy commented Aug 22, 2024

CI still failed.

@Peefy
Copy link
Contributor

Peefy commented Aug 23, 2024

CI still failed. cc @officialasishkumar

@officialasishkumar
Copy link
Contributor Author

sorry for not commenting. i am still fixing it.

Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
@officialasishkumar
Copy link
Contributor Author

@Peefy

The tests are passing on my local machine

https://paste.opensuse.org/pastes/426cb8e8ff62

@Peefy
Copy link
Contributor

Peefy commented Aug 23, 2024

e2e tests Also failed.

/home/runner/work/kpm/kpm/test/e2e/kpm_test.go:36

  Timeline >>
  STEP: create kpm test workspace @ 08/23/24 13:10:32.495
  cloning 'https://github.com/KusionStack/catalog.git' with commit '3891e96'
  failed to compile the kcl package
  open kcl.mod: no such file or directory
  [FAILED] in [It] - /home/runner/work/kpm/kpm/test/e2e/kpm_test.go:53 @ 08/23/24 13:10:33.118
  STEP: clean up kpm test workspace @ 08/23/24 13:10:33.118
  << Timeline

  [FAILED] Expected

@officialasishkumar
Copy link
Contributor Author

officialasishkumar commented Aug 23, 2024

@Peefy
Name and fullName are so tightly synched that it will make the codebase a lot messy if I try to only change fullName to its original form and name to package name. Will it be acceptable to use Package Name passed as full name since there is no way to add more than one package right now? The entire code is run considering that one package.

@Peefy
Copy link
Contributor

Peefy commented Aug 23, 2024

cc @zong-zhe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
2 participants