Rename fullname to reponame #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
|
@Peefy PTAL |
Pull Request Test Coverage Report for Build 10576183537Details
💛 - Coveralls |
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
|
cc @zong-zhe |
|
Hi @officialasishkumar 😄 Add more test cases, for example, compile a KCL package that relies on a git submodule as a dependency and output the correct result. |
Signed-off-by: Asish Kumar <[email protected]>
zong-zhe
pushed a commit
to zong-zhe/kpm
that referenced
this pull request
Sep 2, 2024
* ParseRepoFullNameFromGitSource remove package Signed-off-by: Asish Kumar <[email protected]> * fix kpm add with repo name in full name Signed-off-by: Asish Kumar <[email protected]> * fix kpm graph with repo name in full name Signed-off-by: Asish Kumar <[email protected]> * fix kpm metadata with repo name in full name Signed-off-by: Asish Kumar <[email protected]> * fix unit tests according to the new changes Signed-off-by: Asish Kumar <[email protected]> * remove print statement Signed-off-by: Asish Kumar <[email protected]> * update tests for metadata Signed-off-by: Asish Kumar <[email protected]> * update metadata lock file with repo name Signed-off-by: Asish Kumar <[email protected]> * add unit test for vendor mode metadata Signed-off-by: Asish Kumar <[email protected]> * add unit test for kcl mod run Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: