-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implements missing discard actions #290
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #290 +/- ##
===========================================
- Coverage 77.36% 77.18% -0.19%
===========================================
Files 8 8
Lines 729 745 +16
Branches 121 120 -1
===========================================
+ Hits 564 575 +11
- Misses 130 135 +5
Partials 35 35
Continue to review full report at Codecov.
|
Oh that's great! Thanks a lot @NCenerar for taking the time and effort for producing this PR! That's exactly the kind of code structure that was missing to have a complete implementation of actions. I'm ready to merge it upstream. |
OK, I just fixed the merge conflict (due to other merged PRs). This PR is ready to be pushed upstream! :) |
Glad to help ;) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Implements discard actions.
/closes #270
/closes #146
Preliminary checks
New Features Submissions:
Changes to Core Features: