Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implements missing discard actions #290

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

NCenerar
Copy link
Contributor

Summary

Implements discard actions.
/closes #270
/closes #146

Preliminary checks

New Features Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #290 (5c4bbcb) into develop (fff0d70) will decrease coverage by 0.18%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #290      +/-   ##
===========================================
- Coverage    77.36%   77.18%   -0.19%     
===========================================
  Files            8        8              
  Lines          729      745      +16     
  Branches       121      120       -1     
===========================================
+ Hits           564      575      +11     
- Misses         130      135       +5     
  Partials        35       35              
Impacted Files Coverage Δ
mail_deduplicate/action.py 55.55% <61.11%> (+0.55%) ⬆️
mail_deduplicate/deduplicate.py 75.26% <90.90%> (+0.53%) ⬆️
mail_deduplicate/cli.py 85.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff0d70...5c4bbcb. Read the comment docs.

@kdeldycke
Copy link
Owner

Oh that's great! Thanks a lot @NCenerar for taking the time and effort for producing this PR! That's exactly the kind of code structure that was missing to have a complete implementation of actions.

I'm ready to merge it upstream.

@kdeldycke kdeldycke changed the title ✨ implements discard actions ✨ Implements missing discard actions Sep 12, 2021
@kdeldycke
Copy link
Owner

OK, I just fixed the merge conflict (due to other merged PRs). This PR is ready to be pushed upstream! :)

@NCenerar
Copy link
Contributor Author

Glad to help ;)

@NCenerar NCenerar deleted the feat/discard-actions branch September 12, 2021 10:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
@kdeldycke kdeldycke added ✨ enhancement Improvement or change to an existing feature and removed enhancement labels Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ enhancement Improvement or change to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-s discard-newer -a delete-discarded isn't deleting any mail Implement *-discarded actions
2 participants