-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WINDOW CI PYTHON 3.10 fail pip-compile #1639
Conversation
Signed-off-by: Nok Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! 💪 Any idea why it only complained on windows and not on unix?
@MerelTheisenQB Not really sure about this, it could be caused by the dependencies, so maybe some of them didn't support Window Python 3.10 well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🎉
@noklam More because I don't understand PEP 517/518 particularly well, but I don't understand how this resolves the issue. If you look at the I don't quite understand how changing the build system for Kedro here made a difference. I think the behavior here is honestly equivalent to what's already happening, because it doesn't significantly deviate from the fallback build system. In summary:
Anyway, could also be totally off about this, since I've just been learning more about it since last week. :) |
As another data point, https://app.circleci.com/pipelines/github/kedro-org/kedro/9308/workflows/f57743ea-ed24-4075-b0e3-a50c062d547a/jobs/142356 has it using PEP517 but doesn't fail. |
@deepyaman Could you try re-trigger your PR to see if it will pass? To be honest, I don't understand the issue fully as well, I have noticed my PR fail with the pip-compile test occasionally and it's more stable when I have the I think the problem PEP517 and PEP518 are trying to solve is the |
https://app.circleci.com/pipelines/github/kedro-org/kedro/9592/workflows/ca4978bd-38cd-47ec-a1d8-b9adf3eee257/jobs/146155 is re-running now, and it looks like it built the |
I've got a new idea to deal with the failing
(last two links are internal; sorry, public people) In short, there used to be issues guaranteeing globally-resolvable requirements. Since then (the issue is from 2019), pip's dependency resolver has changed and isn't complete 💩. I personally don't think there would be an issue with just removing the |
@deepyaman That is a radical thought! It does indeed seem that the pip-compile jobs are there largely for historical reasons, but I have found them quite useful for immediately flagging where there's version conflicts and the like. I guess this would still be flagged by the Two things to mention:
|
For point 2, it will be easier for the kedro main repository, but I guess it just shifts the problem to the kedro-datasets repo? |
@AntonyMilneQB this was my understanding! |
Signed-off-by: Nok Chan [email protected]
Description
Fixed fail CI due to pip-compile at #1630
PEP517 and PEP518 are relatively new specifications related to the Python build system. It causes some issue with some of the libraries that we depends on ob.
Development notes
Checklist
RELEASE.md
file