Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: scale-codec in blockifier & starknet-api main #1430

Open
tdelabro opened this issue Feb 2, 2024 · 4 comments
Open

dev: scale-codec in blockifier & starknet-api main #1430

tdelabro opened this issue Feb 2, 2024 · 4 comments
Assignees
@bidzyyys
Labels
backlog Ready to be picked enhancement New feature or request needed-for-mainnet stale

Comments

@tdelabro
Copy link
Collaborator

tdelabro commented Feb 2, 2024 •
edited
Loading

Since #1407 we are able to execute std only code in the runtime. Meaning we are losing the use of our blockifier/starknet-api/cairo-vm forks.
Still, we cannot use the libs directly yet, because we need a lot of the types defined there to implement parity-scale-codec::{Encode, Decode}.
Those impl are already done in our branches on our forks, but we need them on upstream/main now.

That is the purpose of this issue: open PR to the upstream repos, where you add a parity-scale-codec feature and impl/derive the trait (mostly copy-paste from our branch) on every type defined there.
@tdelabro tdelabro added enhancement New feature or request backlog Ready to be picked labels Feb 2, 2024
@bidzyyys
Copy link
Contributor

bidzyyys commented Feb 7, 2024

@tdelabro I can take this one

bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 15, 2024
@bidzyyys
feat: add SCALE Codec to primitive types
aabd8dc 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 15, 2024
@bidzyyys
feat: add SCALE Codec for ThinStateDiff
e2dad16 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 15, 2024
@bidzyyys
feat: add SCALE Codec for ContractClass
c7a3aed 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 16, 2024
@bidzyyys
feat: add SCALE Codec for ExecutionResources
aa90663 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 16, 2024
@bidzyyys
fix: downgrade SCALE Codec to v3.9.5
4b4610e 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 16, 2024
@bidzyyys
feat: add SCALE Codec for Program
ff92c50 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 19, 2024
@bidzyyys
feat: add SCALE Codec for DeprecatedContractClass
6dca2e4 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 20, 2024
@bidzyyys
feat: add SCALE Codec for DeprecatedContractClass
24d321a 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 20, 2024
@bidzyyys
feat: impl SCALE COdec for StateDiff
dce6ced 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Feb 20, 2024
@bidzyyys
feat: impl SCALE COdec for StateDiff
4c4c209 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Feb 20, 2024
@bidzyyys
feat: add SCALE Codec to blockifier repo
520ac87 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Feb 20, 2024
@bidzyyys
feat: add SCALE Codec to Sierra Types
ff98168 
Refers: keep-starknet-strange/madara#1430
This was referenced Mar 1, 2024
Closed
Closed
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Mar 5, 2024
@bidzyyys
wip: move SCALE Codec changes from Madara repository
0118cf8 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/cairo-vm that referenced this issue Mar 8, 2024
@bidzyyys
feat: add SCALE Codec to cairo-vm
29948d8 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/papyrus that referenced this issue Mar 10, 2024
@bidzyyys
feat: support SCALE Codec from external crates
e583fef 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/papyrus that referenced this issue Mar 11, 2024
@bidzyyys
feat: support SCALE Codec from external crates
a584ea6 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Mar 11, 2024
@bidzyyys
wip: move SCALE Codec changes from Madara repository
54098ef 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/cairo that referenced this issue Mar 11, 2024
@bidzyyys
feat: add SCALE Codec to NestedIntList
cecedfa 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/papyrus that referenced this issue Mar 11, 2024
@bidzyyys
feat: support SCALE Codec
d847d6b 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Mar 11, 2024
@bidzyyys
wip: move SCALE Codec changes from Madara repository
7bf085e 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Mar 11, 2024
@bidzyyys
feat: add SCALE Codec to transaction types
4bf3d9a 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/cairo that referenced this issue Mar 12, 2024
@bidzyyys
chore: update dependencies with SCALE Codec
733f377 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/starknet-api that referenced this issue Mar 12, 2024
@bidzyyys
chore: set proper dependencies with SCALE Codec
381c442 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/cairo-vm that referenced this issue Mar 12, 2024
@bidzyyys
chore: update SCALE Codec dependencies
14e7767 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/papyrus that referenced this issue Mar 12, 2024
@bidzyyys
chore: update SCALE Codec dependencies
5e8d23c 
Refers keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Mar 12, 2024
@bidzyyys
chore: update SCALE Codec dependencies
545d71e 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/blockifier that referenced this issue Mar 12, 2024
@bidzyyys
feat: add SCALE Codec to CommitmentStateDiff
128d097 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/cairo-vm that referenced this issue Mar 13, 2024
@bidzyyys
feat: add SCALE Codec to cairo-vm
b53aaa4 
Refers: keep-starknet-strange/madara#1430
(cherry picked from commit 29948d8)
bidzyyys added a commit to bidzyyys/cairo-vm that referenced this issue Mar 13, 2024
@bidzyyys
chore: update SCALE Codec dependencies
0002d30 
Refers keep-starknet-strange/madara#1430

(cherry picked from commit 14e7767)
bidzyyys added a commit to bidzyyys/cairo-vm that referenced this issue Mar 13, 2024
@bidzyyys
feat: add feature parity-scale-codec
a61536e 
Refers: keep-starknet-strange/madara#1430
bidzyyys added a commit to bidzyyys/cairo that referenced this issue Mar 14, 2024
@bidzyyys
chore: update dependencies with parity-scale-codec feature
cbf1ccc 
Refers keep-starknet-strange/madara#1430
tdelabro pushed a commit to bidzyyys/blockifier that referenced this issue Mar 19, 2024
@bidzyyys @tdelabro
a shitload of Encode/Decode/TypeInfo
1622383 
feat: add SCALE Codec to blockifier repo

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to Sierra Types

Refers: keep-starknet-strange/madara#1430

wip: move SCALE Codec changes from Madara repository

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to transaction types

Refers keep-starknet-strange/madara#1430

chore: update SCALE Codec dependencies

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to CommitmentStateDiff

Refers: keep-starknet-strange/madara#1430

feat: scale-info

feat: impl Default for ContractClassV1

chore: encode/decode/scale-info for BlockInfo & GasPrices

chore: add de/serde for GasPrice

add more decode + scale for versioned_consts
@jerrybaoo
Copy link

jerrybaoo commented Mar 31, 2024 •
edited
Loading

I believe this issue is an important prerequisite for upgrading the Cairo and RPC versions. I'd like to know how much work is left to complete. Do we need more people to speed things up?
@bidzyyys @tdelabro

@tdelabro
Copy link
Collaborator Author

It most likely will stay in our forks for a bit more. But most types have proper impl at this point

apoorvsadana pushed a commit to apoorvsadana/blockifier that referenced this issue May 13, 2024
@bidzyyys @apoorvsadana
a shitload of Encode/Decode/TypeInfo
8d1cf50 
feat: add SCALE Codec to blockifier repo

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to Sierra Types

Refers: keep-starknet-strange/madara#1430

wip: move SCALE Codec changes from Madara repository

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to transaction types

Refers keep-starknet-strange/madara#1430

chore: update SCALE Codec dependencies

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to CommitmentStateDiff

Refers: keep-starknet-strange/madara#1430

feat: scale-info

feat: impl Default for ContractClassV1

chore: encode/decode/scale-info for BlockInfo & GasPrices

chore: add de/serde for GasPrice

add more decode + scale for versioned_consts
apoorvsadana pushed a commit to apoorvsadana/blockifier that referenced this issue May 13, 2024
@bidzyyys @apoorvsadana
a shitload of Encode/Decode/TypeInfo
b4c1f92 
feat: add SCALE Codec to blockifier repo

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to Sierra Types

Refers: keep-starknet-strange/madara#1430

wip: move SCALE Codec changes from Madara repository

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to transaction types

Refers keep-starknet-strange/madara#1430

chore: update SCALE Codec dependencies

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to CommitmentStateDiff

Refers: keep-starknet-strange/madara#1430

feat: scale-info

feat: impl Default for ContractClassV1

chore: encode/decode/scale-info for BlockInfo & GasPrices

chore: add de/serde for GasPrice

add more decode + scale for versioned_consts
apoorvsadana pushed a commit to apoorvsadana/blockifier that referenced this issue May 13, 2024
@bidzyyys @apoorvsadana
a shitload of Encode/Decode/TypeInfo
0c71e3f 
feat: add SCALE Codec to blockifier repo

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to Sierra Types

Refers: keep-starknet-strange/madara#1430

wip: move SCALE Codec changes from Madara repository

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to transaction types

Refers keep-starknet-strange/madara#1430

chore: update SCALE Codec dependencies

Refers: keep-starknet-strange/madara#1430

feat: add SCALE Codec to CommitmentStateDiff

Refers: keep-starknet-strange/madara#1430

feat: scale-info

feat: impl Default for ContractClassV1

chore: encode/decode/scale-info for BlockInfo & GasPrices

chore: add de/serde for GasPrice

add more decode + scale for versioned_consts
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bidzyyys bidzyyys

Labels
backlog Ready to be picked enhancement New feature or request needed-for-mainnet stale
Projects
Madara
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bidzyyys @tdelabro @jerrybaoo @apoorvsadana