Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: github CI failing due to starknet-js #1549

Open
hhamud opened this issue Apr 2, 2024 · 9 comments
Open

bug: github CI failing due to starknet-js #1549

hhamud opened this issue Apr 2, 2024 · 9 comments
Labels
bug Something isn't working stale

Comments

@hhamud
Copy link
Contributor

hhamud commented Apr 2, 2024

Bug Report

Madara version:
Latest version on main

Current behavior:
The github ci tests are failing specifically due to the starknet-js tests failing.
Here are the specific logs: #1549 (comment)

This is the specific repo at fault, https://github.com/keep-starknet-strange/sequencer-js-compatibility-tests

Expected behavior:
All tests should pass

Steps to reproduce:
Create a pull request and view the logs.

@hhamud hhamud added the bug Something isn't working label Apr 2, 2024
@princeibs
Copy link

Hi @hhamud, can I try this out?
Though the logs is not displaying from my end
image

@hhamud
Copy link
Contributor Author

hhamud commented Apr 8, 2024

@princeibs I can't assign anything but I am fine with you doing this. you would need to ask @apoorvsadana or @tdelabro for it to be assigned to via github.

Also here is the log as a file.txt: 13_Run starknet-js compatibility tests _ test.txt

and this is the specific github workflow file that is used. https://github.com/keep-starknet-strange/madara/blob/main/.github/workflows/starknet-js-tests.yml

@princeibs
Copy link

Alright sure. Will hop on it 🚀

@princeibs
Copy link

@apoorvsadana @tdelabro
Can you assign me please?

@apoorvsadana
Copy link
Collaborator

Sure @princeibs, assigned to you.

@tdelabro
Copy link
Collaborator

@princeibs any news on this one?

@princeibs
Copy link

Facing a blocker with when starting up madara.
Running this command cargo run --release -- --dev throws the error below:
image
@tdelabro

@tdelabro
Copy link
Collaborator

you have to run cargo run --release -- setup first. The genesis confic file changed, it has one extra field

@princeibs princeibs removed their assignment May 22, 2024
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

4 participants