fix PTR expiration preventing later service resolution #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ran across this issue while using mdns-sd when browsing for a specific service domain. The bug requires the following message pattern to manifest:
ServiceFound
andServiceResolved
ServiceRemoved
ServiceFound
but does not emitServiceResolved
From my understanding of the code, it looks like it assumes that a new SRV or TXT (or another non-PTR) record will be received after a new PTR relying on that to trigger the block responsible for resolving the service.
I've added a test (in the place of least resistance) that reproduces this behaviour.