Always include subtype info if exists #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue #145 (partially it turns out ;-) )
Currently
ServiceInfoonly containssub_domaininfo if the query targets the subtype. Thesub_domainisNoneif it is generated for querying the parent service type.Part of the reason is that we only store mappings from PTR to instance SRV, not the other way. Both parent type PTR and subtype PTR points to the same instance SRV. When querying the parent PTR, we wouldn't know about the subtype PTR from the instance SRV. This patch is to make the reverse lookup possible.