feat: replace remaining box dns with declared type #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After skimming through the code a bit, I found two usages of
Box<dyn DnsRecordExt>
instead of using theDnsRecordBox
type (Box<dyn DnsRecordExt + Send>
).Although in the replaced remaining cases, we dont really use the
Send
bound but this can be done for consistency sake as there are already other usages of it in places where it isn't necessarily needed.