Simplified hub VNET and firewall setup, corrected DNS rules, and stre…

…amlined subnet configuration
kennethcarnes · Feb 5, 2024 · a5f0ced · a5f0ced
1 parent 2599a6d
commit a5f0ced
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/bicep/firewall.bicep b/bicep/firewall.bicep
@@ -142,7 +142,8 @@ resource networkRuleCollection 'Microsoft.Network/firewallPolicies/ruleCollectio
             ]
             protocols: [
               {
-                protocolType: 'UDP'
+                protocolType: 'Udp'
+                port: 53
               }
             ]
           }

diff --git a/bicep/vnets.bicep b/bicep/vnets.bicep
@@ -1,7 +1,7 @@
 param location string
 param hubVnetName string
-param hubSubnet1Prefix string
-param hubSubnet2Prefix string
+param hubSubnet1Prefix string = '10.0.1.0/24'
+param hubSubnet2Prefix string = '10.0.2.0/24'
 param spokeVnetDetails array
 
 // Hub Virtual Network
@@ -13,6 +13,12 @@ resource hubVnet 'Microsoft.Network/virtualNetworks@2021-02-01' = {
       addressPrefixes: ['10.0.0.0/16']
     }
     subnets: [
+      {
+        name: 'AzureFirewallSubnet'
+        properties: {
+          addressPrefix: '10.0.0.0/24'
+        }
+      }
       {
         name: 'Subnet1'
         properties: {
@@ -25,6 +31,7 @@ resource hubVnet 'Microsoft.Network/virtualNetworks@2021-02-01' = {
           addressPrefix: hubSubnet2Prefix
         }
       }
+      // ... other subnets if needed ...
     ]
   }
 }