infamy: Refactor xpath handling between restconf and netconf implment… #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Previous xpath may or may not been an xpath, we still called it xpath. Remove the obscure function get_xpath() and instead transform to a URI in restconf.py This fix issue #490 Signed-off-by: Mattias Walström <[email protected]>
mattiaswal
force-pushed
the
refactor-xpath
branch
from
e86a23c
to
1b07667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous xpath may or may not been an xpath, we still called it xpath. Remove the obscure function get_xpath() and instead transform to a URI in restconf.py
This fix issue #490
All tests run with restconf:
o Execution `-- o 0001-all.yaml |-- o 0002-reproducible.py |-- o 0003-wait.py |-- o 0004-Misc tests | `-- o 0005-operational_all.py |-- o 0006-ietf-system | |-- o 0007-hostname.py | |-- o 0008-add_delete_user.py | |-- o 0009-user_admin.py | |-- o 0010-timezone.py | `-- o 0011-timezone_utc_offset.py |-- o 0012-ietf-interfaces | |-- o 0013-vlan_ping.py | |-- o 0014-ipv4_address.py | |-- o 0015-ipv6_address.py | |-- o 0016-iface_phys_address.py | |-- o 0017-iface_status.py | `-- o 0018-routing_basic.py |-- o 0019-infix-interfaces | |-- o 0020-bridge_basic.py | |-- o 0021-bridge_veth.py | |-- o 0022-dual_bridge.py | |-- o 0023-bridge_vlan.py | |-- o 0024-ipv4_autoconf.py | |-- o 0025-bridge_fwd_sgl_dut.py | |-- o 0026-bridge_fwd_dual_dut.py | |-- o 0027-bridge_vlan_separation.py | |-- o 0028-igmp_basic.py | |-- o 0029-igmp_vlan.py | |-- o 0030-static_multicast_filters.py | `-- o 0031-vlan_qos.py |-- o 0032-ietf-routing | |-- o 0033-static_routing.py | |-- o 0034-ospf_basic.py | |-- o 0035-ospf_unnumbered_interface.py | `-- o 0036-ospf_multiarea.py |-- o 0037-infix-containers | |-- o 0038-container_basic.py | |-- o 0039-container_bridge.py | |-- o 0040-container_phys.py | `-- o 0041-container_veth.py |-- o 0042-infix-dhcp | |-- o 0043-dhcp_basic.py | |-- o 0044-dhcp_router.py | `-- o 0045-dhcp_routes.py `-- o 0046-ietf-hardware `-- o 0047-usb.pyAll tests with netconf:
o Execution `-- o 0001-all.yaml |-- o 0002-reproducible.py |-- o 0003-wait.py |-- o 0004-Misc tests | `-- o 0005-operational_all.py |-- o 0006-ietf-system | |-- o 0007-hostname.py | |-- o 0008-add_delete_user.py | |-- o 0009-user_admin.py | |-- o 0010-timezone.py | `-- o 0011-timezone_utc_offset.py |-- o 0012-ietf-interfaces | |-- o 0013-vlan_ping.py | |-- o 0014-ipv4_address.py | |-- o 0015-ipv6_address.py | |-- o 0016-iface_phys_address.py | |-- o 0017-iface_status.py | `-- o 0018-routing_basic.py |-- o 0019-infix-interfaces | |-- o 0020-bridge_basic.py | |-- o 0021-bridge_veth.py | |-- o 0022-dual_bridge.py | |-- o 0023-bridge_vlan.py | |-- o 0024-ipv4_autoconf.py | |-- o 0025-bridge_fwd_sgl_dut.py | |-- o 0026-bridge_fwd_dual_dut.py | |-- o 0027-bridge_vlan_separation.py | |-- o 0028-igmp_basic.py | |-- o 0029-igmp_vlan.py | |-- o 0030-static_multicast_filters.py | `-- o 0031-vlan_qos.py |-- o 0032-ietf-routing | |-- o 0033-static_routing.py | |-- o 0034-ospf_basic.py | |-- o 0035-ospf_unnumbered_interface.py | `-- o 0036-ospf_multiarea.py |-- o 0037-infix-containers | |-- o 0038-container_basic.py | |-- o 0039-container_bridge.py | |-- o 0040-container_phys.py | `-- o 0041-container_veth.py |-- o 0042-infix-dhcp | |-- o 0043-dhcp_basic.py | |-- o 0044-dhcp_router.py | `-- o 0045-dhcp_routes.py `-- o 0046-ietf-hardware `-- o 0047-usb.py