Accept type parameters on grammar (e.g. lifetimes) (Fixes #220) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the parser to operate over types like `Token<'code>` by
supplying the lifetime as a type parameter on the grammar:
```
peg::parser! {
grammar feeny<'a>() for Tokens<'a> {
// snip
}
}
```
This should work with all type parameters, not just lifetimes, but
lifetimes are the motivating example here.
Like @kevinmehall's comment on kevinmehall#220 suggests, this simply adds
`rust_ty_params()` to `peg_grammar` in the meta-grammar, and then
threads that through.
If a rule defines it's own type parameters, those come after the
grammar's type parameters on the parser's exported
functions/entrypoints.
Fixes kevinmehall#220
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the parser to operate over types like
Token<'code>by supplying the lifetime as a type parameter on the grammar (#220):This should work with all type parameters, not just lifetimes, but lifetimes are the motivating example here.
Like @kevinmehall's comment on #220 suggests, this simply adds
rust_ty_params()topeg_grammarin the meta-grammar, and then threads that through.If a rule defines it's own type parameters, those come after the grammar's type parameters on the parser's exported functions/entrypoints.