This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
Update for memleak in AsyncHTTPSRequest_Impl_Generic.h #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @roel80 Thanks for the terrific fix, which is one of the reasons causing crashes / memory-leak. I also spot another bug causing crash at the beginning or using full I'll spend some more time to test, fix and clean up the code, before merging and publish a new better version. Best Regards, |
Not using magic number
khoih-prog
approved these changes
Oct 20, 2022
khoih-prog
added a commit
that referenced
this pull request
Oct 20, 2022
khoih-prog
added a commit
that referenced
this pull request
Oct 20, 2022
khoih-prog
added a commit
that referenced
this pull request
Oct 20, 2022
|
Hi @roel80 The AsyncHTTPSRequest_Generic v2.2.0 has just been released. Your contribution is noted in Contributions and Thanks. Please help with more rigorous tests to see if there is any more memory-related issues. As you know, there is so much a guy can do, especially with too many libraries to develop and take care, without the help of many more people. Still waiting for more bug reports and fixes from you ;=}} The library is better and better thanks to contribution users like you. Best Regards, Releases v2.2.0
|
|
The latest test is so good. No crash and stable heap. Thanks for everybody involved, @roel80. @nilber |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for memory leak