This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
Fix QNEthernet TCP interface #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now compiles. Also remove unnecessary yield() calls.
ssilverman
force-pushed
the
fix-qnethernet
branch
from
2e41d8b
to
01448ff
Compare
|
Thanks for your PR. I didn't spend time to retest your library recently, which has been upgraded a lot, and am not aware of the compiler-error issue. Thanks a lots for you PR, which is tested and running great now. A new release will be published soon and your contribution will be noted. Best Regards, |
|
The reason those yield() calls can be deleted is because all those functions now internally call Ethernet::loop(). The compiler error was because EthernetServer only has a “port” constructor and must be recreated when listening on a new port. I might explore adding a |
khoih-prog
added a commit
that referenced
this pull request
Dec 18, 2021
### Release v1.9.1 1. Fix compile error for `Teensy 4.1` using new [QNEthernet library version](https://github.com/ssilverman/QNEthernet). Check [Fix QNEthernet TCP interface #35](#35) 2. Update `Packages' Patches` 3. Verify working with new Arduino IDE `v1.8.18` 4. Update `library.json` and `platform.ini` newly published [QNEthernet library](https://github.com/ssilverman/QNEthernet)
khoih-prog
added a commit
that referenced
this pull request
Dec 18, 2021
### Release v1.9.1 1. Fix compile error for `Teensy 4.1` using new [QNEthernet library version](https://github.com/ssilverman/QNEthernet). Check [Fix QNEthernet TCP interface #35](#35) 2. Update `Packages' Patches` 3. Verify working with new Arduino IDE `v1.8.18` 4. Update `library.json` and `platform.ini` newly published [QNEthernet library](https://github.com/ssilverman/QNEthernet)
khoih-prog
added a commit
that referenced
this pull request
Dec 18, 2021
### Release v1.9.1 1. Fix compile error for `Teensy 4.1` using new [QNEthernet library version](https://github.com/ssilverman/QNEthernet). Check [Fix QNEthernet TCP interface #35](#35) 2. Update `Packages' Patches` 3. Verify working with new Arduino IDE `v1.8.18` 4. Update `library.json` and `platform.ini` newly published [QNEthernet library](https://github.com/ssilverman/QNEthernet)
|
Hi Shawn, Just published the new WebSockets2_Generic releases v1.9.1 with a note about your contribution in Contributions and Thanks. Hoping to get more PRs from you. Best Regards, Release v1.9.1
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now compiles. Also remove unnecessary yield() calls.