Avoid invalid expression and type mismatch

[davebv]

Invalid expression error is produced when trying to open certain tags: This avoids the error:

Error detected while processing function 57_AcceptSelection:
line 30:
E685: Internal error: get_tv_string_buf()
E15: Invalid expression: type == 'dict' ? [{ 'action': md, 'line': line, 'icr': icr }] : [md, line]
line 31:
E121: Undefined variable: actargs
E116: Invalid arguments for function call

[davebv]

Invalid expression error was triggered with this line.

[kien]

Can you provide steps to reproduce the error? Does updating Vim help? It looks like the parser confuses the colons in the Dictionary with operators.

[davebv]

To reproduce the error:

1. Create tags file in ctags
2. :CtrlPTags
3. Search for any tag and try to open it.
4. Error pops up.

Tested with vim 7.1

[kien]

Thanks! I can't reproduce it in Vim 7.1.0 to 7.4.0, but in 7.0.0. Looks like it's an old bug with the parser when Dictionary was new. I use ternary operators often, however, so I may have to change a few other places as well.

[davebv]

Thank you for the quick response! 👍

[d11wtq]

@davebv is this still an issue? Wondering if this needs merging into https://github.com/ctrlpvim/ctrlp.vim or not.

[davebv]

I believe this will help when using dictionaries in Vim. I have problems with 7.1 but cannot reproduce it in newer versions.