Allow ctrlp_user_command to not have '%s' in it #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this command _always_ executed: `printf(lscmd, path)`, and lscmd is set to the value of ctrlp_user_command if that value is set. The problem is that if ctrlp_user_command does not have a %s in it, then printf command receives, as its first parameter, a string that doesn't have %s in it. However, it also receives a second parameter. This causes printf to throw an error saying that there are too many parameters. That error is silently caught (line 351). The net result is that the users experiences the symptom of seeing the message "NO ENTRIES" every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this command always executed:
printf(lscmd, path), andlscmd is set to the value of ctrlp_user_command if that value is set.
The problem is that if ctrlp_user_command does not have a %s in it, then
printf command receives, as its first parameter, a string that doesn't
have %s in it. However, it also receives a second parameter. This causes
printf to throw an error saying that there are too many parameters. That
error is silently caught (line 351). The net result is that the users
experiences the symptom of seeing the message "NO ENTRIES" every time.