Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

songlists don't handle display width #138

Closed
shmibs opened this issue Dec 16, 2023 · 3 comments
Closed

songlists don't handle display width #138

shmibs opened this issue Dec 16, 2023 · 3 comments
Labels

Comments

@shmibs
Copy link

shmibs commented Dec 16, 2023

it seems SongListWidget naïvely tries just to display one rune into one cell, but this won't work for most? of unicode. i think there are multiple issues here of like:

  • a wide character rune like あ has display width 2 rather than 1
  • a character is not always just one rune, with combining characters and such

to handle this "properly" must be quite hard (looks like tcell library has issue discussion about), but for at least displaying wide characters it must be easier partial fix. currently a name like 青葉市子 gets displayed as 青市, because wide chars overflow into the next cell displaying. it seems tcell used https://github.com/mattn/go-runewidth for this?

@kimtore
Copy link
Owner

kimtore commented Dec 23, 2023

Hi @shmibs, thanks for reporting.

Try the latest build and see if that fixes the issue?
My dataset is somewhat limited when it comes to wide character unicode.
There might be other UI elements affected where this issue might pop up again, feel free to address them in this issue as well if you find any.

@shmibs
Copy link
Author

shmibs commented Dec 23, 2023

ah yes, this seems working in songlists now!

and mmm, but it's still doing the same in the now-playing, list name, etc

2023-1703343482

@kimtore
Copy link
Owner

kimtore commented Dec 24, 2023

@shmibs,
I sorted out all the issues I could find regarding wide characters.
Feel free to open another issue if you find more of these.

@kimtore kimtore closed this as completed Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants