Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix so that Trust Boundary in Trust Boundary can be selected correctly #109

Closed
Tethik opened this issue Jul 2, 2024 · 1 comment · Fixed by #113
Closed

Fix so that Trust Boundary in Trust Boundary can be selected correctly #109

Tethik opened this issue Jul 2, 2024 · 1 comment · Fixed by #113
Assignees
@Tethik
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@Tethik
Copy link
Member

Tethik commented Jul 2, 2024

If you create two Trust Boundaries in the diagram, then put the first on you created inside the second one, you won't be able to select it again as the second one counts as ordered higher in the diagram and therefore will get the click event first.

A user can easily workaround this by moving the boxes around, creating them in a certain order etc, but it would be neat if there was some automatic ordering happening or Trust Boundaries would adjust their clickable area to maybe only being close to their border.
@Tethik Tethik added enhancement New feature or request good first issue Good for newcomers bug Something isn't working labels Jul 2, 2024
@Tethik
Copy link
Member Author

Tethik commented Jul 4, 2024

trust-boundary-poc

Demo of bug

@Tethik Tethik self-assigned this Aug 13, 2024
Tethik added a commit that referenced this issue Aug 13, 2024
@Tethik
fix: make it so smaller trust boundaries can be selected while inside…
27f900a 
… another. Fixes #109
@Tethik Tethik mentioned this issue Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tethik Tethik

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make it so smaller trust boundaries can be selected while inside… klarna-incubator/gram
1 participant
@Tethik