-
-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* WIP: Opening up toolbar for customizations Add McPickerBarButtonItems and tests * Start using McPickerBarButtonItem’s * Use McPickerBarButtonItem in example Update README * Bump release version to 0.5.0 🚀
- Loading branch information
Showing
11 changed files
with
363 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| line_length: 200 | ||
| cyclomatic_complexity: 5 | ||
| file_length: | ||
| warning: 500 | ||
| error: 1200 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
Example/McPicker.xcodeproj/xcshareddata/xcschemes/McPicker_Tests.xcscheme
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion = "0830" | ||
| version = "1.3"> | ||
| <BuildAction | ||
| parallelizeBuildables = "YES" | ||
| buildImplicitDependencies = "YES"> | ||
| </BuildAction> | ||
| <TestAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| shouldUseLaunchSchemeArgsEnv = "YES"> | ||
| <Testables> | ||
| <TestableReference | ||
| skipped = "NO"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "607FACE41AFB9204008FA782" | ||
| BuildableName = "McPicker_Tests.xctest" | ||
| BlueprintName = "McPicker_Tests" | ||
| ReferencedContainer = "container:McPicker.xcodeproj"> | ||
| </BuildableReference> | ||
| </TestableReference> | ||
| </Testables> | ||
| <AdditionalOptions> | ||
| </AdditionalOptions> | ||
| </TestAction> | ||
| <LaunchAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| launchStyle = "0" | ||
| useCustomWorkingDirectory = "NO" | ||
| ignoresPersistentStateOnLaunch = "NO" | ||
| debugDocumentVersioning = "YES" | ||
| debugServiceExtension = "internal" | ||
| allowLocationSimulation = "YES"> | ||
| <AdditionalOptions> | ||
| </AdditionalOptions> | ||
| </LaunchAction> | ||
| <ProfileAction | ||
| buildConfiguration = "Release" | ||
| shouldUseLaunchSchemeArgsEnv = "YES" | ||
| savedToolIdentifier = "" | ||
| useCustomWorkingDirectory = "NO" | ||
| debugDocumentVersioning = "YES"> | ||
| </ProfileAction> | ||
| <AnalyzeAction | ||
| buildConfiguration = "Debug"> | ||
| </AnalyzeAction> | ||
| <ArchiveAction | ||
| buildConfiguration = "Release" | ||
| revealArchiveInOrganizer = "YES"> | ||
| </ArchiveAction> | ||
| </Scheme> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| /* | ||
| Copyright (c) 2017 Kevin McGill <[email protected]> | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
| The above copyright notice and this permission notice shall be included in | ||
| all copies or substantial portions of the Software. | ||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
| */ | ||
|
|
||
| import UIKit | ||
| import XCTest | ||
| @testable import McPicker | ||
|
|
||
| // swiftlint:disable nesting | ||
| // swiftlint:disable force_cast | ||
| class McPickerBarButtonItemTests: XCTestCase { | ||
|
|
||
| let mcPicker = McPicker(data: [["Bob", "Bill"]]) | ||
|
|
||
| func testInitDone_noTitleDefaultStyle() { | ||
| let item = McPickerBarButtonItem.done(mcPicker: mcPicker) | ||
|
|
||
| XCTAssertNil(item.title) | ||
| XCTAssertTrue(item.style == .done) | ||
| XCTAssertTrue(item.target as! McPicker == mcPicker) | ||
| XCTAssertTrue(item.action == #selector(McPicker.done)) | ||
| } | ||
|
|
||
| func testInitDone_noTitleCustomStyle() { | ||
| let item = McPickerBarButtonItem.done(mcPicker: mcPicker, barButtonSystemItem: UIBarButtonSystemItem.save) | ||
|
|
||
| XCTAssertNil(item.title) | ||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertTrue(item.target as! McPicker == mcPicker) | ||
| XCTAssertTrue(item.action == #selector(McPicker.done)) | ||
| } | ||
|
|
||
| func testInitDone_withTitle() { | ||
| let title = "My Custom Title" | ||
| let item = McPickerBarButtonItem.done(mcPicker: mcPicker, title: title) | ||
|
|
||
| XCTAssertTrue(item.title == title) | ||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertTrue(item.target as! McPicker == mcPicker) | ||
| XCTAssertTrue(item.action == #selector(McPicker.done)) | ||
| } | ||
|
|
||
| func testInitCancel_noTitle() { | ||
| let item = McPickerBarButtonItem.cancel(mcPicker: mcPicker) | ||
|
|
||
| XCTAssertNil(item.title) | ||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertTrue(item.target as! McPicker == mcPicker) | ||
| XCTAssertTrue(item.action == #selector(McPicker.cancel)) | ||
| } | ||
|
|
||
| func testInitCancel_noTitleCustomStyle() { | ||
| let item = McPickerBarButtonItem.cancel(mcPicker: mcPicker, barButtonSystemItem: UIBarButtonSystemItem.save) | ||
|
|
||
| XCTAssertNil(item.title) | ||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertTrue(item.target as! McPicker == mcPicker) | ||
| XCTAssertTrue(item.action == #selector(McPicker.cancel)) | ||
| } | ||
|
|
||
| func testInitCancel_withTitle() { | ||
| let title = "My Custom Title" | ||
| let item = McPickerBarButtonItem.cancel(mcPicker: mcPicker, title: title) | ||
|
|
||
| XCTAssertTrue(item.title == title) | ||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertTrue(item.target as! McPicker == mcPicker) | ||
| XCTAssertTrue(item.action == #selector(McPicker.cancel)) | ||
| } | ||
|
|
||
| func testInitFlexibleSpace() { | ||
| let item = McPickerBarButtonItem.flexibleSpace() | ||
|
|
||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertNil(item.target) | ||
| XCTAssertNil(item.action) | ||
| } | ||
|
|
||
| func testInitFixedSpace() { | ||
| let expectedWidth: CGFloat = 2.0 | ||
| let item = McPickerBarButtonItem.fixedSpace(width: expectedWidth) | ||
|
|
||
| XCTAssertTrue(item.width == expectedWidth) | ||
| XCTAssertTrue(item.style == .plain) | ||
| XCTAssertNil(item.title) | ||
| XCTAssertNil(item.target) | ||
| XCTAssertNil(item.action) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.