Add support of an array of price buckets and standard granuarlities #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granularities such as auto or dense
kmjennison
requested changes
Nov 8, 2020
There was a problem hiding this comment.
@mike-chowla Thanks for this contribution! It looks good.
Before merging, I'd like to:
- Add tests for each price bucket setting in
test_add_new_prebid_partner.py - Update the README to include the new options
Update Prebid Universal Creative snippet to include `hbPb` in tag data
Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.1.2 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.1.2...5.4) Signed-off-by: dependabot[bot] <[email protected]>
…ml-5.4 Bump pyyaml from 5.1.2 to 5.4
# Conflicts: # requirements.txt
…rsion Update Ad Manager API version
granularities such as auto or dense
…p-prebid-setup into dense-granularity
|
Closing this in favor #111 which has the updates requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Issue #27 Auto / Dense price granularity
Adds supports for an array of price buckets as well as standard Prebid price granularities: auto, dense, medium, low