build: update CI node versions (#30)

* build: bump CI node version * build: add node 20.x to CI test environments * Fix test error on node 20 with webpack 4 --------- Co-authored-by: Kevin Montag <[email protected]>
kmontag · May 17, 2023 · 1e09836 · 1e09836
1 parent a315750
commit 1e09836
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 16.x, 18.x]
+        node-version: [12.x, 16.x, 18.x, 20.x]
         webpack-version: [2, 3, 4, 5]
 
     env:
@@ -25,18 +25,18 @@ jobs:
       - run: npm ci
       - run: npm run build --if-present
 
-      # For node 18.x, the webpack hashing functions (which get called
-      # separately from this loader during compilation) throw errors
-      # unless we force the legacy SSL provider.
-      - run: ${{ matrix.node-version == '18.x' && 'NODE_OPTIONS=--openssl-legacy-provider ' || '' }}npm test
+      # For node 18 and 20, the webpack4 hashing functions (which get
+      # called separately from this loader during compilation) throw
+      # errors unless we force the legacy SSL provider.
+      - run: ${{ (matrix.webpack-version == '4' && (matrix.node-version == '18.x' || matrix.node-version == '20.x')) && 'NODE_OPTIONS=--openssl-legacy-provider ' || '' }}npm test
 
   validate:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '18.x'
       - run: npm ci
       - run: npm run check
       - run: npm run lint
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '18.x'
       - run: npm ci
       - run: npm run build --if-present
       - run: npm test