Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check public URL before presigned URL generation #1148

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix: check public URL before presigned URL generation #1148

merged 1 commit into from
Jan 16, 2023

Conversation

rhnvrm
Copy link
Collaborator

@rhnvrm rhnvrm commented Jan 16, 2023

Fixes #1141

@rhnvrm rhnvrm requested a review from knadh January 16, 2023 09:37
@rhnvrm
Copy link
Collaborator Author

rhnvrm commented Jan 16, 2023

With custom URL set, generate URL with Public URL.

image

image

Without custom URL set, generate resigned URL

image

@knadh knadh merged commit 72d22d4 into knadh:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knadh knadh Awaiting requested review from knadh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using private S3 bucket and public CloudFront (CDN) URL together does not work correctly
2 participants
@rhnvrm @knadh