Svg images support #1217
Closed
Svg images support #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I checked Gmail and it doesn't support inserting or rendering SVGs. Thunderbird does. Could you share some popular e-mail clients that support SVG? |
|
Hi, |
knadh
reviewed
Mar 6, 2023
|
|
||
| return c.JSON(http.StatusOK, okResp{true}) | ||
| } | ||
|
|
||
| // generate a png thumbnail of src | ||
| func getSVGThumb(src multipart.File) (image.Image, error) { |
There was a problem hiding this comment.
I think we don't need this at all. SVG is vector, so for thumbnails, it can just be scaled down and rendered. The thumb path and the full path can be the same image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now svg images are supported in nearly all email clients and have many advantages for logo for example.
This adds support for svg image in uploads