Enable extra system calls in systemd service #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runningnoodle this is curious. There have been no changes in v2.4.0 that should do this. No library that should also exhibit this behaviour. Would like to figure out this behaviour somehow before we merge this. |
|
I closed by accident. The last two commits were also accidents. Sorry about the mess I'm creating. |
rhnvrm
approved these changes
May 10, 2023
There was a problem hiding this comment.
Based on the investigation at #1310 and NixOS/nixpkgs#197443
I think it might be okay to remove @resources
|
When trying to start service, I am getting; |
|
Try running listmonk on a port above 1024 instead of 392.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1310.
Since v2.4.0, it looks like Listmonk is making system calls for changing resource limits, memory or scheduling parameters. This PR allows those system calls in the systemd service configuration. This allows Listmonk to run as a systemd service.
The downside of this change is that it weakens the sandbox around the Listmonk process when run as a systemd service. I don't fully understand how systemd works, but I don't expect any serious consequence.