Cleanup sample config #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using localhost instead of some random string is much more likely to actually work out of the box. Also it's a lot easier for a sysamdmin to 'scan' for things that need changing.
This is a small safety precaution to make sure the out of the box configuration is not world routeable. Bringing this up on a public interface with a connected database could be a security concern. Any sysadmin worth their salt is going to test offline or by binding to localhost only first anyway, but this gets them started on the right foot and makes sure people don't make mistakes. Also with the high likelihood that a proxy is going to be used for HTTPS termination anyway, the decision to move to a public IP should be more deliberate.
|
This is a vestige of the indentation I applied when there were dozens and dozens of keys and it was painful to read and parse mentally. Thankfully, all of that has now moved to the UI. |
knadh
reviewed
May 7, 2021
TOML does have a convention of indenting sections, but typically subsections are indented below sections. Keys inside sections are indented at the same level as their section headings. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message comments for details. The TOML formatting wasn't invalid, it's just non-traditional and annoyed me a lot. The other two changes to sample configs are just sysadmin convenience and more safety out of the box.