Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiffy up containerized dev stack #668

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

avanier
Copy link
Contributor

@avanier avanier commented Jan 19, 2022

This PR suggests a few minor changes that should make the containerized dev stack a bit easier to start.

In it's current state the stack will error out on the config.toml file being absent, and that message easily gets buried under the rather verbose logs produced by the frontend stack. Likewise, initializing the database did not reliably work.

@mr-karan
Copy link
Collaborator

@avanier Thanks for this.

I always had dev/config.toml in my local clone but looks like the global .gitignore had omitted it, hence the error you faced.

Apart from that, changes LGTM 👍

cc @knadh

@knadh knadh merged commit 5c2005d into knadh:master Jan 20, 2022
@avanier avanier deleted the upkeep/spiffy-up-docker-dev-stack branch January 20, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants