klogs-plugin: add links integration
#444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,9 +10,28 @@ import ( | |||
| "go.uber.org/zap" | |||
| ) | |||
|
|
|||
| func (i *instance) enrichAutolinks(fields []Field) []Field { | |||
| autolinkIntegrations := make([]IntegrationAutolinks, 0) | |||
There was a problem hiding this comment.
I don't expect this slice to become huge, same with i.integrations. If desired we can filter the autolinkIntegrations slice outside of this method (which is invoked on every request). Furthermore I could make it a map[string]IntegrationAutolinks with the columnName as key. This would further reduce the overhead in L22-L26.
| return; | ||
| } | ||
|
|
||
| path = path.replaceAll('<<value>>', value); |
There was a problem hiding this comment.
We could also use a pattern here instead. For example:
# autolink.path = /goto?foo=$1
# autolink.match = bar-(.*)
value = bar-1234
# resolves to
path = /goto?foo=1234
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 43.77% 43.76% -0.02%
==========================================
Files 143 143
Lines 12396 12424 +28
==========================================
+ Hits 5426 5437 +11
- Misses 6829 6846 +17
Partials 141 141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #255 for the klogs plugin. It allows users to specify a column name and a path to direct users to a different plugin inside kobs or any other place (grafana, jaeger, etc.). It's possible to:
<<value>>(this is replaced with the actual document value for the specific column) and/ortimeStartandtimeEnd(with<<timeStart>>and<<timeEnd>>). This can be useful to create a query for a different platform that benefits from limited time-ranges (e.g jaeger or grafana).