Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable following of non-created profiles #10444

Merged
merged 6 commits into from
Jul 3, 2024
Merged

feat: Enable following of non-created profiles #10444

merged 6 commits into from
Jul 3, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 10, 2024 11:44
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team June 10, 2024 11:44
@netlify Netlify
Copy link

netlify bot commented Jun 10, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b9fa6c7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66827fe32308be0008efc49f
😎 Deploy Preview https://deploy-preview-10444--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jarsen136 Jarsen136 requested a review from hassnian June 10, 2024 11:45
@hassnian hassnian removed the request for review from daiagi June 12, 2024 09:05
@vikiival vikiival requested review from hassnian and prury and removed request for prury June 12, 2024 10:48
@prury
Copy link
Member

prury commented Jun 12, 2024

working for polkadot, but not for base
not sure how its working as worker isn't merged/deployed 🥲

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jun 12, 2024 •
edited
Loading

working for polkadot, but not for base

Could you please make a follow-up issue for the following profile on Base? As they are target to different branches... (main and feat/evm/01)

not sure how its working as worker isn't merged/deployed 🥲

I have deployed it to beta env.

@prury
Copy link
Member

prury commented Jun 12, 2024

working for polkadot, but not for base

Could you please make a follow-up issue for the following profile on Base? As they are target to different branches... (main and feat/evm/01)

sure!

not sure how its working as worker isn't merged/deployed 🥲

I have deployed it to beta env.

oh, nice!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 12, 2024
@prury prury mentioned this pull request Jun 12, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Jun 15, 2024
Open
Merged
vikiival
vikiival reviewed Jun 16, 2024
View reviewed changes
components/profile/ProfileDetail.vue Outdated Show resolved Hide resolved
components/profile/follow/Tab.vue Outdated Show resolved Hide resolved
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 1, 2024

Code Climate has analyzed commit b9fa6c7 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 requested a review from vikiival July 1, 2024 10:08
@Jarsen136 Jarsen136 enabled auto-merge July 2, 2024 18:04
@Jarsen136 Jarsen136 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into kodadot:main with commit 07ff3ed Jul 3, 2024
19 checks passed
@Jarsen136 Jarsen136 deleted the issue-10424-main branch July 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@hassnian hassnian hassnian approved these changes

Assignees

@prury prury

Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable following of non-created profiles
4 participants
@Jarsen136 @prury @vikiival @hassnian