Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Click on following/followers tab with a disconnected account #10467

Closed
wants to merge 5 commits into from
Closed

fix: Click on following/followers tab with a disconnected account #10467

wants to merge 5 commits into from

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 12, 2024 12:24
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team June 12, 2024 12:24
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6c9052e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6676cc43e250cf0008d88783
😎 Deploy Preview https://deploy-preview-10467--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented Jun 12, 2024

same happens here:

image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jun 12, 2024 •
edited
Loading

same happens here:

The problem is that the testing address follows the address on both base and ahp. For now the support for evm related would be implemented only on the feat/evm/v0 branch.

In short, it should be fixed on this issue #10466

Could you test with another address? @prury

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Jun 12, 2024

same happens here:

The problem is that the testing address follows the address on both base and ahp. For now the support for evm related would be implemented only on the feat/evm/v0 branch.

In short, it should be fixed on this issue #10466

Could you test with another address? @prury
image

oh ok, it works then

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 12, 2024
This was referenced Jun 15, 2024
Closed
Merged
@Jarsen136
Copy link
Contributor Author

@vikiival @hassnian could you code review?

@Jarsen136 Jarsen136 changed the base branch from main to feat/evm/v0 June 21, 2024 08:38
codeclimate[bot]
codeclimate bot reviewed Jun 21, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7917 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 21, 2024

Code Climate has analyzed commit 0beeb83 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 6

View more on Code Climate.

hassnian
hassnian requested changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if signaturePair is nullish the functions continue as if it was successful

CleanShot.2024-06-22.at.08.58.38.mp4

services/profile.ts Outdated Show resolved Hide resolved
components/profile/FollowButton.vue Outdated Show resolved Hide resolved
components/profile/FollowButton.vue Outdated Show resolved Hide resolved
components/profile/follow/UserRow.vue Outdated Show resolved Hide resolved
services/profile.ts Outdated Show resolved Hide resolved
components/profile/follow/UserRow.vue Outdated Show resolved Hide resolved
components/profile/FollowButton.vue Outdated Show resolved Hide resolved
@Jarsen136
Copy link
Contributor Author

if signaturePair is nullish the functions continue as if it was successful

CleanShot.2024-06-22.at.08.58.38.mp4

Thanks, all updated

@vikiival vikiival deleted the branch kodadot:feat/evm/v0 June 23, 2024 19:18
@vikiival vikiival closed this Jun 23, 2024
@vikiival
Copy link
Member

Can you change branch pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@hassnian hassnian hassnian requested changes

@vikiival vikiival Awaiting requested review from vikiival vikiival was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click on following/followers tab with a disconnected account?
4 participants
@Jarsen136 @prury @vikiival @hassnian