Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the modifiers declared in the type #86

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Use the modifiers declared in the type #86

merged 1 commit into from
Mar 23, 2023

Conversation

serras
Copy link
Collaborator

@serras serras commented Mar 23, 2023

This PR fixes #85. Until now we were always creating public functions and types, with this change we use the same modifiers as were declared in the type (for example, if the type is internal, the Mutable type and copy functions are also internal).

@serras serras requested a review from pablisco March 23, 2023 11:59
@serras serras self-assigned this Mar 23, 2023
@serras serras merged commit 2800bc0 into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablisco pablisco pablisco approved these changes

Assignees

@serras serras

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support explicit API mode
2 participants
@serras @pablisco