Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kind for local setup #6

Merged
merged 14 commits into from
Nov 24, 2021
Merged

add kind for local setup #6

merged 14 commits into from
Nov 24, 2021

Conversation

MChorfa
Copy link
Contributor

@MChorfa MChorfa commented Oct 20, 2021

This addition will allow to spin up a local KinD cluster.

! One small caveat is we have to change the setting of a workspace from remote to local via the UI for now, when running from within the kind folder

…netes into add-kind

* 'add-kind' of ssh://github.com/MChorfa/multi-cloud-kubernetes:
  Update variables.tf
@ksatirli
Copy link
Owner

Hey @MChorfa,

Thank you for the contribution - I'll go through it and leave feedback!

Setting the workspace to local execution makes sense, of course.

README.md Outdated Show resolved Hide resolved
@ksatirli
Copy link
Owner

Overall, this looks great @MChorfa - thank you for the work!

I've left a few comments to make the docs stronger.

yes make more sens

Co-authored-by: Kerim Satirli <[email protected]>
@MChorfa MChorfa requested a review from ksatirli October 24, 2021 21:29
@ksatirli
Copy link
Owner

Hey @MChorfa - we've got a few more things open before we can merge this.

Can you have a look at the suggestions and let me know what you think?


## Downstream Consumption

The Kubernetes Cluster can be consumed via the [kind_cluster](https://kind.sigs.k8s.io/docs/user/quick-start/) data source:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this line is interesting, because a data source would be the right approach, but there currently is none for kind_cluster specifically (looking at https://github.com/kyma-incubator/terraform-provider-kind/tree/master/kind).

That being said, this and lines #13-18 might need an update to reflect the consumption through a normal resource (vs. a data source).

Does that make sense?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you are right there is no data-source . Sorry for the confusion

clusters/kind/main.tf Outdated Show resolved Hide resolved
clusters/kind/main.tf Outdated Show resolved Hide resolved
clusters/kind/main.tf Show resolved Hide resolved
clusters/kind/main.tf Show resolved Hide resolved
clusters/kind/terraform.tfvars.sample Outdated Show resolved Hide resolved
clusters/kind/terraform.tfvars.sample Outdated Show resolved Hide resolved
clusters/kind/variables.tf Outdated Show resolved Hide resolved
clusters/kind/variables.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
clusters/kind/main.tf Show resolved Hide resolved
clusters/kind/terraform.tfvars.sample Outdated Show resolved Hide resolved
clusters/kind/outputs.tf Outdated Show resolved Hide resolved
Copy link
Owner

@ksatirli ksatirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor changes left @MChorfa - this is looking great!

@MChorfa MChorfa requested a review from ksatirli October 29, 2021 21:03
@ksatirli ksatirli merged commit c1f30cd into ksatirli:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants