-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kind for local setup #6
Conversation
…netes into add-kind * 'add-kind' of ssh://github.com/MChorfa/multi-cloud-kubernetes: Update variables.tf
Hey @MChorfa, Thank you for the contribution - I'll go through it and leave feedback! Setting the workspace to |
Overall, this looks great @MChorfa - thank you for the work! I've left a few comments to make the docs stronger. |
yes make more sens Co-authored-by: Kerim Satirli <[email protected]>
Hey @MChorfa - we've got a few more things open before we can merge this. Can you have a look at the suggestions and let me know what you think? |
clusters/kind/README.md
Outdated
|
||
## Downstream Consumption | ||
|
||
The Kubernetes Cluster can be consumed via the [kind_cluster](https://kind.sigs.k8s.io/docs/user/quick-start/) data source: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this line is interesting, because a data source would be the right approach, but there currently is none for kind_cluster
specifically (looking at https://github.com/kyma-incubator/terraform-provider-kind/tree/master/kind).
That being said, this and lines #13-18 might need an update to reflect the consumption through a normal resource (vs. a data source).
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep you are right there is no data-source . Sorry for the confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor changes left @MChorfa - this is looking great!
This addition will allow to spin up a local KinD cluster.
! One small caveat is we have to change the setting of a workspace from
remote
tolocal
via the UI for now, when running from within thekind
folder