Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close tmp file #1729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close tmp file #1729

wants to merge 1 commit into from

Conversation

testwill
Copy link
Contributor

Purpose of PR?:

Fixes #
close tmp file
Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: guoguangwu <[email protected]>
@daemon1024
Copy link
Member

Hey @testwill
This looks like a valid thing to do. Might I ask why did you notice this? Or were there any issues you faced in the context to get this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants