Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart corrections and additions #2

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

KittyKatt
Copy link

Chart Additions:

  • Ability to specify existing volume claim for panel pods.
  • Ability to use and specify hostname for external mariadb and redis instances. This cancels creation and sourcing of the mariadb and redis subcharts.
    • Adds ability to specify database name and a password for Redis authentication should you choose one.
  • Ability to specify additional annotations for Kubectyl Ingress, Service, StatefulSet, and Deployment resources.
  • Full documentation on all values and defaults available in values.yaml.

Chart Fixes:

  • There is no latest tag for either the panel or kuber images. This switches them to the correct develop tag.
  • Splits ingress to be more sane and match the service resources.
  • Corrects all ports to actually match throughout the stack and no longer requires SSL/HTTPS communication between the service endpoints and the load balancer.
  • Adds some missing labels.
  • Can specify timezone for panel (timezone for kuber still static to UTC).

I'll be making another PR on the source to correct the generated Kuber configuration as the above changes alone will need manual follow-up intervention to disable SSL, change the port, and use the correct sftp-server image tag.

@KittyKatt KittyKatt force-pushed the kat-helm-chart-corrections-1 branch 2 times, most recently from 43bac07 to c000437 Compare April 20, 2024 04:24
…abase name and redis authentication

Signed-off-by: Katie Bohnenkamper <[email protected]>
…management outside of chart

Signed-off-by: Katie Bohnenkamper <[email protected]>
…nger requiring SSL communication beween load balancer and services

Signed-off-by: Katie Bohnenkamper <[email protected]>
Signed-off-by: Katie Bohnenkamper <[email protected]>
@KittyKatt KittyKatt force-pushed the kat-helm-chart-corrections-1 branch from c000437 to 40aa14e Compare April 20, 2024 04:28
@KittyKatt
Copy link
Author

Only after looking through https://github.com/kubectyl/panel/blob/develop/.github/docker/entrypoint.sh am I realizing that I could have just not specified an email and would have accomplished the non-encrypted nginx.conf however I do still think that would be broken.

I am of the opinion that the load balancer should handle SSL termination and that there's really no reason to add the complexity of encrypting the traffic between the load balancer and the service, so I will be keeping that in mind and modifying the the entrypoint-sh to no longer use SSL for nginx or kuber.

@DecDuck
Copy link

DecDuck commented Apr 20, 2024

Perhaps this will fix the issues I was having with setting Kubectyl up. I'll spin up a cluster and see if this works - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants