-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Syncing Kubernetes Client versions with upstream Kubernetes versions #1244
Comments
/kind design |
Using 0.x.y corresponding to Kubernetes 1.x.y has the following downsides:
|
(For the record:) The proposal was accepted in the bi-weekly client-python meeting, and has been implemented for client v17: https://github.com/kubernetes-client/python#homogenizing-the-kubernetes-python-client-versions. Please feel free to close this issue once the action items are finished. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale Issue is not resolved. Python Client 18.0.0 and Python Client 19.0.0 are not released yet. Hence their release notes cannot contain information about the change in versioning scheme. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale This is in progress. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
According to kubernetes-client#1244 the information about the change in the versioning scheme should be added one last time in the version 19.0.0. Did that. That way issue 1244 could also be closed.
/remove-kind design |
/remove-lifecycle rotten |
We are now releasing Kubernetes Python clients with the above-accepted semver. No actions are required for this issue. |
/remove-lifecycle frozen |
@palnabarun: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Current Scenario
The Kubernetes Python client follows a versioning schema
x.y.z{a|b}N
where x isKubernetes Minor Version - 4
. For example, the Kubernetes Python client 12.0.0 is based on Kubernetes 1.16.Reasons
To make the numbering coherent and reduce confusion.
What other clients do
Proposed Versioning Schemes
We can have a versioning scheme similar to client-go. Kubernetes 1.x.y would correspond to Python client 0.x.y.
Or, the versions can be 1.x.y exactly equal to the Kubernetes versions. This results in us being not able to do our own patch releases since there are changes done on the client code too. Also, the client-go adopted the conventions they have currently because of certain limitations with Go Modules, which we don't have. Moving back version numbers is also detrimental since
pip install kubernetes
without a version number canAnother option we have is to have client releases versioned as
x.y.p
where x is the Kubernetes Minor release number, y is the Kubernetes patch release number, and p is the Python client patch specific number. In order to achieve this option, client releases henceforth will jump a few version numbers to achieve the coherency, and the same needs to be documented in the README and CHANGELOG along with proper communication to k-dev when the release happens.Resolution
Based on the discussion in the bi-weekly meeting, it looks like the latter option is preferable.
Action Items
release-17.0
branch for client based on Kubernetes 1.17.p @roycaihw / @yliaogrelease-18.0
branch for client based on Kubernetes 1.18.p @roycaihw / @yliaogrelease-19.0
branch for client based on Kubernetes 1.19.p @roycaihw / @yliaogEdits
/assign
The text was updated successfully, but these errors were encountered: