-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multi-push ci failed #1552
Conversation
Signed-off-by: bitliu <[email protected]>
CC @wilsonwu, could you have a look and review on this? I am not 100% sure, because I am get used to use GitHub Actions to build/push multi-arch image, not cloudbuild. This is kind of weird for me : ( |
/hold |
/cc @wilsonwu |
@Xunzhuo: GitHub didn't allow me to request PR reviews from the following users: wilsonwu. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Xunzhuo! Just one comment but otherwise LGTM
Co-authored-by: Rob Scott <[email protected]>
I viewed the doc of this image, but I also can't run it in my local env, and from the docs I think we can have a try. |
/hold cancel |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bitliu [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1514
Does this PR introduce a user-facing change?: