Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-push ci failed #1552

Merged
merged 2 commits into from
Nov 21, 2022
Merged

fix: multi-push ci failed #1552

merged 2 commits into from
Nov 21, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Nov 21, 2022

Signed-off-by: bitliu [email protected]

What type of PR is this?

/kind bug
What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1514

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2022
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Nov 21, 2022

CC @wilsonwu, could you have a look and review on this?

I am not 100% sure, because I am get used to use GitHub Actions to build/push multi-arch image, not cloudbuild. This is kind of weird for me : (

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Nov 21, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2022
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Nov 21, 2022

/cc @wilsonwu

@k8s-ci-robot
Copy link
Contributor

@Xunzhuo: GitHub didn't allow me to request PR reviews from the following users: wilsonwu.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wilsonwu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xunzhuo! Just one comment but otherwise LGTM

cloudbuild.yaml Outdated Show resolved Hide resolved
Co-authored-by: Rob Scott <[email protected]>
@wilsonwu
Copy link
Contributor

CC @wilsonwu, could you have a look and review on this?

I am not 100% sure, because I am get used to use GitHub Actions to build/push multi-arch image, not cloudbuild. This is kind of weird for me : (

I viewed the doc of this image, but I also can't run it in my local env, and from the docs I think we can have a try.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Nov 21, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2022
@robscott
Copy link
Member

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit a8f72f5 into kubernetes-sigs:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conformance: Test that webhook validations are performed
4 participants