Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP 1651]: Routability Conformance #2171

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[GEP 1651]: Routability Conformance #2171

merged 1 commit into from
Jul 11, 2023

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jul 7, 2023 •
edited
Loading

This PR depends on the following PRs merging

View just the commit with the conformance test here - 4298344

What type of PR is this?
/kind feature
/kind gep
/kind test
/area conformance

What this PR does / why we need it:
This adds conformance tests for the Routability feature

Which issue(s) this PR fixes:

Part of #1651

Does this PR introduce a user-facing change?:

Add conformance tests for Gateway Routability

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2023
@dprotaso dprotaso force-pushed the gep-1651-conformance branch 4 times, most recently from 67e3fbb to 4298344 Compare July 7, 2023 21:08
@shaneutt
Copy link
Member

/cc

@shaneutt shaneutt added this to the v0.8.0 milestone Jul 10, 2023
@candita
Copy link
Contributor

candita commented Jul 11, 2023

I added a few comments. Looks good, almost like a first step towards support for load balancing.

@shaneutt shaneutt requested a review from robscott July 11, 2023 14:29
shaneutt
shaneutt approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty comprehensive, thanks @dprotaso!

Once Candace's comments are resolved, I think this looks good to me

/approve

But @robscott I think you should give this a pass too if you have some time, for the final LGTM.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
shaneutt
shaneutt approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty comprehensive, thanks @dprotaso!

Once Candace's comments are resolved, I think this looks good to me

/approve

But @robscott I think you should give this a pass too if you have some time, for the final LGTM.

howardjohn
howardjohn reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robscott
Copy link
Member

Thanks @dprotaso! This will need to be rebased once #2144 and #2157 merge, but everything LGTM.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 11, 2023
@dprotaso
Copy link
Contributor Author

@robscott rebased

@robscott
Copy link
Member

Thanks @dprotaso!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit a44374f into kubernetes-sigs:main Jul 11, 2023
4 checks passed
@sunjayBhatia sunjayBhatia mentioned this pull request Jul 20, 2023
Closed
@candita candita mentioned this pull request Sep 22, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@candita candita candita left review comments

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dprotaso @shaneutt @candita @robscott @k8s-ci-robot @howardjohn