Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Candace Holman and Grant Spence to GEP Reviewers #2419

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Sep 22, 2023

Gateway API is a community first and foremost and we love to recognize individuals for their contributions.

@candita and @gcs278 have been active members of the community for a long time. Candace has notably been the champion of GEP-1897 (BackendTLSPolicy), and Grant has worked tirelessly on GEP-1619 (Session Persistence). Both of them have worked hard and proven their skills building this API, and as such we want to recognize both of them as our first GEP Reviewers so that they can continue helping us shape the future of Gateway API in an official capacity. Thank you Candace! Thank you Grant! 🥳

/kind documentation
/kind gep

Does this PR introduce a user-facing change?:

NONE

Notes:

DRAFT while we move their KSIGs sponsorship forward:

@shaneutt shaneutt added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 22, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 22, 2023
@shaneutt shaneutt marked this pull request as draft September 22, 2023 18:24
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2023
@shaneutt shaneutt removed this from the v1.0.0 milestone Sep 27, 2023
@robscott robscott marked this pull request as ready for review October 6, 2023 00:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@robscott
Copy link
Member

robscott commented Oct 6, 2023

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@robscott
Copy link
Member

robscott commented Oct 6, 2023

/verify-owners

@robscott
Copy link
Member

robscott commented Oct 6, 2023

@candita maybe you need to formally accept a GitHub membership invite? Looks like you should be in the system per https://github.com/kubernetes/org/blob/47384d500d2ffdaeaa3a9f4f7bb6465dafff283d/config/kubernetes-sigs/org.yaml#L146.

@candita
Copy link
Contributor

candita commented Oct 10, 2023

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 10, 2023
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Oct 10, 2023
@shaneutt shaneutt self-assigned this Oct 10, 2023
@shaneutt shaneutt added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 10, 2023
@youngnick
Copy link
Contributor

/retest

@youngnick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit bfdb703 into kubernetes-sigs:main Oct 11, 2023
8 checks passed
@shaneutt shaneutt deleted the shaneutt/gep-reviewers branch October 11, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants