Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize legacy fields #4933

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Localize legacy fields #4933

merged 1 commit into from
Jan 4, 2023

Conversation

annasong20
Copy link
Contributor

This PR localizes the legacy kustomization fields, loaded in #4918.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2022
natasha41575
natasha41575 reviewed Dec 22, 2022
View reviewed changes
api/internal/localizer/localizer_test.go Outdated
kustomization := map[string]string{
// We test that `kustomize localize` ignores helm charts. The code neither
// accesses the referenced file, which does not exist, nor copies it to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this with @yuwenma and @KnVerey after the holidays. I agree that we should not handle localization of helm fields in alpha, but silently ignoring it doesn't seem to be the right thing to do. I think our options here are to either copy it over as-is, throw a warning, or throw an error if we see use of the helm field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing offline, @natasha41575 and I concluded that this PR can be merged without addressing helm fields, as the PR doesn't make any changes specific to helm. We'll discuss the particulars after the holidays; in the meantime, I'll try to copy local files to the localize destination.

natasha41575
natasha41575 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

One minor point of discussion that we should resolve before release.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 22, 2022
@natasha41575 natasha41575 mentioned this pull request Dec 22, 2022
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2022
@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6949c83 into kubernetes-sigs:master Jan 4, 2023
@annasong20 annasong20 deleted the localize-legacy branch January 4, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 approved these changes

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annasong20 @k8s-ci-robot @natasha41575