Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some Location fields optional #70

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

kulapard
Copy link
Owner

@kulapard kulapard commented Jun 7, 2024

Fixes #67

@github-actions github-actions bot added the fix label Jun 7, 2024
@kulapard kulapard changed the title make some Location field optional make some Location fields optional Jun 7, 2024
@kulapard kulapard merged commit c4a2e75 into main Jun 7, 2024
10 checks passed
@kulapard kulapard deleted the fix/67-missing-country branch June 7, 2024 16:19
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (0c5dbfc) to head (95cb65e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   94.90%   94.91%           
=======================================
  Files          13       13           
  Lines         550      551    +1     
=======================================
+ Hits          522      523    +1     
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with converting larger journals
1 participant