Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): specify package.json location (#823) #1013

Merged

Conversation

jdhuntington
Copy link
Contributor

@jdhuntington jdhuntington commented Mar 4, 2019

Addresses issues #823 and #852

@coveralls
Copy link

coveralls commented Mar 4, 2019

Pull Request Test Coverage Report for Build 2523

  • 6 of 14 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 91.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/config/config-set.ts 6 14 42.86%
Totals Coverage Status
Change from base Build 2522: -0.3%
Covered Lines: 915
Relevant Lines: 967

💛 - Coveralls

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 6, 2019

Hi, would you please link to a related issue in the description or from any discussions ?

@jdhuntington
Copy link
Contributor Author

Addresses issues #823 and #852

@GeeWee
Copy link
Collaborator

GeeWee commented Mar 8, 2019

This looks good to me. Can you update the docs as well?

Document the package.json config option.
@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 12, 2019

Once your branch is in sync with master, we can merge this PR 👍

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 13, 2019

I think we can merge this @GeeWee @kulshekhar

@jdhuntington
Copy link
Contributor Author

Please let me know if you'd like me to rebase+push instead of the merge commit. Thanks!

@GeeWee GeeWee merged commit fb7dd55 into kulshekhar:master Mar 14, 2019
@GeeWee
Copy link
Collaborator

GeeWee commented Mar 14, 2019

Perfectly fine as is. Thanks for your contribution!

@kulshekhar
Copy link
Owner

Sorry for the delay. A new version has now been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants