Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache collisions #751

Merged
merged 7 commits into from
Sep 22, 2018
Merged

Fix cache collisions #751

merged 7 commits into from
Sep 22, 2018

Conversation

huafu
Copy link
Collaborator

@huafu huafu commented Sep 22, 2018

  • Adds a ts-jest digest to the bundle & cache key. The digest depends on all the files included in the bundle (except the digest file itself)
  • Fixes possible cache collisions when using a tsConfig file with "extends" #749: possible cache collisions due to the use of input tsconfig instead of resolved one (this would happen if the config was a file with extends: ...
  • Improves e2e config extending logic
  • Enables compilation caching for unit and e2e in CI now that we depend on the bundle digest
  • Ensure the local version of binaries are used within npm scripts

For reviewers: most of the changes are in tests and test utilities. Only source files changed:

  • src/compiler.ts
  • src/config/config-set.ts
  • src/index.ts
  • package.json - ensures local versions of binaries are called within scripts

@huafu huafu added this to the 23.10.2 milestone Sep 22, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1883

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 91.142%

Totals Coverage Status
Change from base Build 1882: 0.4%
Covered Lines: 971
Relevant Lines: 1016

💛 - Coveralls

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM

@huafu huafu merged commit 25e1c63 into kulshekhar:master Sep 22, 2018
@huafu huafu deleted the fix-cache-collisions branch September 22, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible cache collisions when using a tsConfig file with "extends"
3 participants