Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module warning => message not throwing #753

Merged
merged 8 commits into from
Sep 25, 2018

Conversation

huafu
Copy link
Collaborator

@huafu huafu commented Sep 22, 2018

Fixes #748 by emitting a message without throwing in case module kind is not compatible with commonjs and neither esModuleInterop nor allowSyntheticDefaultImports is set.

FYI we must enforce commonjs module as Jest relies on it.


revieweer(s): only source file changed: src/config/config-set.ts – others are unit and e2e tests, with a snapshot for each module-kind/import modifiers config options

Diagnostics have a category. By default if warnOnly is not set, when
diagnostic(s) of kind message or suggestion will be raised, ts-jest will
log it but not throw. This also changes the category of the internal
TS151000.

Closes kulshekhar#748
@huafu huafu added this to the 23.10.2 milestone Sep 22, 2018
@coveralls
Copy link

coveralls commented Sep 22, 2018

Pull Request Test Coverage Report for Build 1890

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 91.135%

Totals Coverage Status
Change from base Build 1889: -0.007%
Covered Lines: 975
Relevant Lines: 1020

💛 - Coveralls

@huafu huafu added the hotfix label Sep 24, 2018
@huafu huafu mentioned this pull request Sep 24, 2018
5 tasks
@huafu huafu merged commit 22fec2b into kulshekhar:master Sep 25, 2018
@huafu huafu deleted the fix-module-warning branch September 25, 2018 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants