Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(kuma-cp): paginate Secrets correctly in universal (backport of #1…
…0954) (#10956) * fix(kuma-cp): paginate Secrets correctly in universal (#10954) We were wrapping a store that already had a pagination store with another pagination store. This led to inconsistent results like: ``` % kumactl get secrets --mesh nonprod --size 1000 | grep -v MESH | wc -l 450 % kumactl get secrets --mesh nonprod --offset 100 | grep -v MESH | wc -l 0 ``` Only k8s stores needs to be wrapped with a pagination store, the default store for universal is already paginated: https://github.com/kumahq/kuma/blob/7075f0e17466c73ec82aa95649124edad6cafe8d/pkg/core/bootstrap/bootstrap.go#L295-L301 https://github.com/kumahq/kuma/blob/7075f0e17466c73ec82aa95649124edad6cafe8d/pkg/plugins/secrets/universal/plugin.go#L17 Signed-off-by: Mike Beaumont <[email protected]> * fix conflicts Signed-off-by: Jay Chen <[email protected]> --------- Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: Jay Chen <[email protected]> Co-authored-by: Mike Beaumont <[email protected]> Co-authored-by: Jay Chen <[email protected]>
- Loading branch information